Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scrape timeout header for consistency #2581

Closed
mdlayher opened this Issue Apr 5, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mdlayher @juliusv
@mdlayher
Copy link
Member

mdlayher commented Apr 5, 2017

...shouldn't we use X-Prometheus-Scrape-Timeout-Seconds instead? We prefix all our other headers with X-Prometheus-

Created from discussion in #2565.
@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented Apr 5, 2017

Yes, I think we should! But you knew that ;)
@mdlayher

This comment has been minimized.

Sign in to view
Copy link
Member Author

mdlayher commented Apr 5, 2017

Yep, just making a GitHub issue to make sure it gets done.

@mdlayher mdlayher referenced this issue Apr 5, 2017

Merged

retrieval: make scrape timeout header consistent with others #2582

@juliusv juliusv closed this in #2582 Apr 5, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.