Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCommit 947c83b... breaks with go1.6 #2584
Comments
This comment has been minimized.
This comment has been minimized.
|
It has been explicitly decided that we can break compat with 1.6. |
This comment has been minimized.
This comment has been minimized.
|
Yes, we worry about compat for client_golang but not anything else. |
brian-brazil
closed this
Apr 6, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
jayeye commentedApr 6, 2017
•
edited
I tried building from master (5f764d9...) on a machine with go1.6 (the default for ubuntu server 16.04), and got
I knew I had successfully built in v1.5.2 (bd1182d...).
git bisectis my second-best friend, and shows me that the offending commit is 947c83b..., which according to the log followed shortly after an upgrade to go1.8 (5f764d9... builds fine with go1.8).If compatibility with older versions of go is required, maybe someone should look into this before the next release is cut.