Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote read should validate returned labelnames #2586

Closed
brian-brazil opened this Issue Apr 6, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Apr 6, 2017

While playing around I managed to create a labelname called 12a, which is clearly invalid.

We should validate the returned labelnames, and reject results with invalid ones.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Apr 7, 2017

And the metric name.

@juliusv juliusv added the help wanted label Apr 26, 2017

@ankitm123

This comment has been minimized.

Copy link

ankitm123 commented Jun 2, 2017

If no one's working on this, I can take a look at it this weekend.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jun 2, 2017

That'd be great!

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.