Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated histogram_quantile produces incorrect, unstable results #2598

Closed
lmb opened this Issue Apr 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@lmb
Copy link

lmb commented Apr 7, 2017

What did you do?

Aggregated a set of histograms, using

histogram_quantile(1, sum(irate(timeseries[3m])) by (le))

What did you expect to see?

Realistic, constant results.

What did you see instead? Under which circumstances?

Every evaluation of the promql generates a different result. There are spikes which go to the max bucket, even though the underlying data shows no such behaviour.

I've tried changing the resolution, etc. parameters, but that doesn't seem to make a difference. Also happens at q = 0.99, but seems more pronounced at q = 1.

Some screenshots for demonstration:

Unaggregated:
Unaggregated histograms

Aggregated, first execution:
Aggregated, first execution

Aggregated, second execution:
Aggregated, second execution

Environment

  • Prometheus version:

    Version 1.5.2
    Revision 16a512fe91926e2e3d0b1d2da6e7e16ceeab5f02

  • client_golang version:

    334af0119a8f8fb6af5bb950d535c482cac7f836
    
  • Prometheus configuration file:

Scrapes happen every 60s.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 7, 2017

This is #1893.

@lmb

This comment has been minimized.

Copy link
Author

lmb commented Apr 7, 2017

  1. Issue #1887 (which apparently led to #1893) talks about graphing federated metrics. The histograms I'm aggregating are scraped by the same prometheus instance.
  2. I've tried searching for this issue on the bug tracker. Seems like none of the open issues mention histograms, and all the other ones have been closed (such as this one).
  3. The documentation on prometheus.io states that histograms can be aggregated. Is that a false statement?
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.