Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upGetBoundaryValues() and GetRangeValues() should return labels in SampleSets #26
Comments
ghost
assigned
matttproud
Jan 8, 2013
This comment has been minimized.
This comment has been minimized.
|
@juliusv, is this still relevant? |
This comment has been minimized.
This comment has been minimized.
|
The view and storage methods now only take fingerprints, so while some of them still do metric lookups for those, I don't want to require them to do that anymore (and don't need it). Right now I get the fingerprints myself in the view adapter and this is fine. Closing this. |
juliusv
closed this
Mar 28, 2013
matttproud
added a commit
that referenced
this issue
Apr 9, 2014
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 25, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
juliusv commentedJan 8, 2013
I've only tested GetRangeValues() so far, but maybe GetBoundaryValues() has the same behavior. The SampleSets that get returned have a nil-map as the Metric member, whereas they should probably contain the labels that the function was called with, to yield a proper timeseries.
It's not a big problem right now, because the caller has the right labels anyways and can insert them. However, I'm not sure if that's intended.