Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upValidate samples coming from remote read? #2601
Comments
juliusv
added
area/stability
component/remote storage
labels
Apr 7, 2017
This comment has been minimized.
This comment has been minimized.
|
Dupe of #2586 |
brian-brazil
closed this
Apr 7, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
juliusv commentedApr 7, 2017
Although slightly different, https://groups.google.com/forum/#!topic/prometheus-users/ajWG7y-DtCg made me note that a remote read endpoint could send us back invalid metric or label names. Should we check their validity when receiving the read response? If so, what do we do with invalid samples? Fail the query?