Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFile-based service discovery doesn't accept relative paths to files #2603
Comments
This comment has been minimized.
This comment has been minimized.
|
#2247 covers this. |
brian-brazil
closed this
Apr 7, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
it-praktyk commentedApr 7, 2017
•
edited
I tried configure the file-based service discovery with file pattern relatative to the main Prometheus configuration catalog (usually /etc/prometheus).
I've found that only full path is accepted - not relative path.
In my opinion issue is related to the line https://github.com/prometheus/prometheus/blob/master/discovery/file/file.go#L85 what currently is
paths = append(paths, files...)In opposite rule files can be provided with a relative path because the line https://github.com/prometheus/prometheus/blob/master/config/config.go#L63 contains the additional command
resolveFilepaths(filepath.Dir(filename), cfg)Confirmed with Prometheus 1.5.2.