Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-based service discovery doesn't accept relative paths to files #2603

Closed
it-praktyk opened this Issue Apr 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@it-praktyk
Copy link

it-praktyk commented Apr 7, 2017

I tried configure the file-based service discovery with file pattern relatative to the main Prometheus configuration catalog (usually /etc/prometheus).

I've found that only full path is accepted - not relative path.

In my opinion issue is related to the line https://github.com/prometheus/prometheus/blob/master/discovery/file/file.go#L85 what currently is
paths = append(paths, files...)

In opposite rule files can be provided with a relative path because the line https://github.com/prometheus/prometheus/blob/master/config/config.go#L63 contains the additional command
resolveFilepaths(filepath.Dir(filename), cfg)

Confirmed with Prometheus 1.5.2.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 7, 2017

#2247 covers this.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.