Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uplimitAppender should fail the whole scrape #2608
Comments
brian-brazil
added
the
dev-2.0
label
Apr 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Ah, I see the Rollback() call now. |
brian-brazil
closed this
Apr 11, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedApr 11, 2017
In the new code, limitAppender only stops ingesting samples after the limit is hit. Instead it should not ingest any scraped samples if the limit is hit.
By ingesting an arbitrary set of samples, semantics become muddy and it may not prevent the churn issues this protection mechanism is mean to handle.