Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtool check-metrics: bits vs bytes #2617

Open
mdlayher opened this Issue Apr 13, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@mdlayher
Copy link
Member

mdlayher commented Apr 13, 2017

Creating a new issue from the discussion in: #2605.

Some of the current open questions:

  • Should this tool provide both "errors" and "warnings"?
  • Do warnings vs. errors make the tool less useful for CI purposes?
  • Does it make for network metrics or metrics such as "available bits of entropy" to remain as bits instead of bytes?
  • Can the conversion for humans just be handled by a tool like Grafana, or multiplying/dividing by 8 where needed?

Feel free to continue the discussion here.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Apr 14, 2017

From @brian-brazil:

If the choice is between allowing a mix of bit and bytes, and having an exception for entropy I say we switch entropy to bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.