Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtool check-metrics: error on "_total" for non-counters, "_count" for non-summaries #2618

Closed
mdlayher opened this Issue Apr 13, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mdlayher
@mdlayher
Copy link
Member

mdlayher commented Apr 13, 2017

Issue created from: #2605 (comment).

_total on non-counters, and _count on non-summaries are other ones to look out for

In addition, the tool should probably check that:

  • _total is not used for metrics which are not counters
  • _count is not used for metrics which are not summaries

This was referenced Apr 14, 2017

Merged
Merged

@brian-brazil brian-brazil closed this in #2626 Apr 15, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.