Cleanup flags prior to 2.0 release

[brian-brazil]

There's various old/deprecated flags we should get rid of (e.g. old alertmanagers flag). This issue is to remind us to do it.

[fabxc]

This seems mostly done. We have just a handful of flags left.

   -version false
   -config.file "prometheus.yml"
   -alertmanager.notification-queue-capacity 10000
   -alertmanager.timeout 10s
   -log.format "\"logger:stderr\""
   -log.level "\"info\""
   -query.max-concurrency 20
   -query.staleness-delta 5m0s
   -query.timeout 2m0s
   -storage.local.engine "persisted"     <<< remove?
   -storage.local.path "data"                 <<< mv storage.tsdb.path
   -storage.tsdb.max-block-duration 0s
   -storage.tsdb.min-block-duration 2h0m0s
   -storage.tsdb.no-lockfile false
   -storage.tsdb.retention 360h0m0s
   -web.console.libraries "console_libraries"
   -web.console.templates "consoles"
   -web.enable-remote-shutdown false
   -web.external-url
   -web.listen-address ":9090"
   -web.max-connections 512
   -web.read-timeout 30s
   -web.route-prefix
   -web.telemetry-path "/metrics"         <<< drop this? 
   -web.user-assets

overwriting the /metrics path seems pointless. We don't allow randomly rewriting anything else, so what's the reason to do it here? The route prefix allows for all practical cases I assume.

[brian-brazil]

overwriting the /metrics path seems pointless.

Many of our exporters permit it, for reasons that aren't really clear to me.

-query.staleness-delta 5m0s

Pretty sure this isn't used in 2.0.

[fabxc]

So should we ditch /metrics flag for 2.0?

Staleness delta is still used in plenty of cases as our window for how far we look back for instant queries mostly. Even with staleness solved, this needs to be specified somehow. But is the name still apropriate.

[brian-brazil]

So should we ditch /metrics flag for 2.0?

I'd be in favour, however we'd need to get consensus on removing it from all the other components too.

Staleness delta is still used in plenty of cases as our window for how far we look back for instant queries mostly.

We don't use the flag value in 2.0, we use the constant StalenessDelta.

[gouthamve]

We do have a constant value of 5mins, but it can be updated via the flag here <https://github.com/prometheus/prometheus/blob/dev-2.0/cmd/prometheus/config.go#L159-L163> Should we keep it configurable?

…

On Thu, Jun 15, 2017 at 2:42 PM Brian Brazil ***@***.***> wrote: So should we ditch /metrics flag for 2.0? I'd be in favour, however we'd need to get consensus on removing it from all the other components too. Staleness delta is still used in plenty of cases as our window for how far we look back for instant queries mostly. We don't use the flag value in 2.0, we use the constant StalenessDelta. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHA3HzWHDNkpe4CRmJxi3zjWwTKUqYMhks5sEPWWgaJpZM4NAIIL> .

[fabxc]

I'd be in favour, however we'd need to get consensus on removing it from all the other components too.

@SuperQ @grobie @discordianfish you are dealing a lot with exporters doing this. Opinions?

[SuperQ]

Yes, we should remove /metrics flag from our components. I don't see a need to provide an override for this in our own code. The only use case is for reverse proxies, but these can be adjusted by users.

[grobie]

I've never changed the metrics path of an exporter. To be honest it's mostly cargo cult that I included the flag in all exporters I wrote. I wonder if we should reach out to prometheus-users and check whether anyone has a good argument to keep them.

…

On Thu, Jun 15, 2017 at 11:43 AM Ben Kochie ***@***.***> wrote: Yes, we should remove /metrics flag from our components. I don't see a need to provide an override for this in our own code. The only use case is for reverse proxies, but these can be adjusted by users. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAANaGOhWeHf7cQvJgwKK3HG9KYyA3feks5sEPzbgaJpZM4NAIIL> .

[brian-brazil]

From the requests I've seen it seems to be users trying to be consistent with some of their applications that use a (single) non-standard path.

[fabxc]

This is done.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.