Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Prometheus URL, really is valid #2691

Closed
jswitzer opened this Issue May 8, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
2 participants
@jswitzer @brian-brazil
@jswitzer
Copy link
Contributor

jswitzer commented May 8, 2017

ERRO[0000] invalid Prometheus URL: http://mon0.kira.np.:9090/ source=main.go:75

The problem appears to be that the version of govalidator currently within this repository doesn't include an upstream fix for fully qualified urls.

This particular issue was fixed here:
asaskevich/govalidator#193

Should I try to put together a PR with a govalidator version update?
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member

brian-brazil commented May 8, 2017

Yes please.

@jswitzer jswitzer referenced this issue May 12, 2017

Merged

vendor: upgrade govalidator to v6 #2714

@brian-brazil brian-brazil closed this May 15, 2017

@brian-brazil brian-brazil added the kind/bug label May 15, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.