Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for minumum go version requirement #2698

Closed
siavashs opened this Issue May 9, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@siavashs @Colstuwjx @juliusv
@siavashs
Copy link

siavashs commented May 9, 2017

Trying to build promtool with golang < 1.8 produces this error message:

/path/to/gopath/src/github.com/prometheus/prometheus/util/promlint/promlint.go:86: undefined: sort.SliceStable

As I checked sort.SliceStable was added in golang-1.8
@Colstuwjx

This comment has been minimized.

Sign in to view
Copy link
Contributor

Colstuwjx commented May 20, 2017

+1, I also met a build issue:

vendor/k8s.io/client-go/rest/request.go:21:2: cannot find package "context" in any of:

We should add go version requirement since context is part of go 1.7+

@Colstuwjx Colstuwjx referenced this issue May 20, 2017

Merged

Fix go version hint. #2750

@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented May 20, 2017

Done in #2750

@juliusv juliusv closed this May 20, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.