Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate vendored github.com/Sirupsen/logrus #2732
Comments
This comment has been minimized.
This comment has been minimized.
|
Would you like to send a PR? |
This comment has been minimized.
This comment has been minimized.
|
Have a look at the govendor update command:
https://github.com/kardianos/govendor
…On Wed, May 17, 2017 at 10:00 PM Brian Brazil ***@***.***> wrote:
Would you like to send a PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2732 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANaDzgjMnyJVCcxep5iLv0SLjOCclSks5r61HEgaJpZM4NeWcX>
.
|
fazalmajid
referenced this issue
May 17, 2017
Merged
updated logrus so Prometheus can build on Solaris/Illumos #2733
This comment has been minimized.
This comment has been minimized.
|
Sure, I was just unclear about the project's policy on updating dependencies. I just submitted the PR #2733 |
fazalmajid
closed this
May 17, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
fazalmajid commentedMay 17, 2017
prometheus won't build in Solaris because the vendored version of logrus is ancient and doesn't include the file terminal_solaris.go that provides IsTerminal():
https://github.com/sirupsen/logrus/commits/master/terminal_solaris.go
Removing the vendored logrus and building it from HEAD (currently master = 5e5dc898656f695e2a086b8e12559febbfc01562) lets Prometheus build successfully.