Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `TieredStorage.flushMemory()` testable and test it #274
Comments
This comment has been minimized.
This comment has been minimized.
|
/cc @matttproud |
This comment has been minimized.
This comment has been minimized.
|
The old storage is gone. Closing this. |
juliusv
closed this
Dec 10, 2014
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
juliusv commentedMay 28, 2013
I fixed a bug in
TieredStorage.flushMemory()in a8468a2 where the condition for what to keep in memory vs. what to flush to disk was reversed.Unfortunately, this method is not good to test: it uses
time.Now()to decide what to flush. Make this method more testable and test it.