Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock in `TieredStorage.flushMemory()` #275

Closed
juliusv opened this Issue May 28, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@juliusv
Copy link
Member

juliusv commented May 28, 2013

AFACIS t.appendToDiskQueue is produced and consumed only from the same goroutine, in sequence, with no capacity checking on the producer side. That looks like the producer could potentially deadlock forever if the channel fills up, because the consumer would only run after it.

@ghost ghost assigned matttproud May 28, 2013

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented May 29, 2013

Great catch. There were so many things that changed in that last
simplification round that I could imagine how this would have been
overlooked.
Am 28.05.2013 17:23 schrieb "juliusv" notifications@github.com:

AFACIS t.appendToDiskQueue is produced and consumed only from the same
goroutine, in sequence, with no capacity checking on the producer side.
That looks like the producer could potentially deadlock forever if the
channel fills up, because the consumer would only run after it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/275
.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented Dec 10, 2014

The old storage is gone. Closing this.

@juliusv juliusv closed this Dec 10, 2014

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.