Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix potential deadlock in `TieredStorage.flushMemory()` #275
Comments
ghost
assigned
matttproud
May 28, 2013
This comment has been minimized.
This comment has been minimized.
|
Great catch. There were so many things that changed in that last
|
This comment has been minimized.
This comment has been minimized.
|
The old storage is gone. Closing this. |
juliusv
closed this
Dec 10, 2014
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
juliusv commentedMay 28, 2013
AFACIS
t.appendToDiskQueueis produced and consumed only from the same goroutine, in sequence, with no capacity checking on the producer side. That looks like the producer could potentially deadlock forever if the channel fills up, because the consumer would only run after it.