Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfile_sd should have a metric for the timestamps of the files it's using #2757
Comments
brian-brazil
added
low hanging fruit
priority/P3
help wanted
and removed
help wanted
labels
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Some pointers: The text file collector does it by having a map and updating it on every read. We could have the same translated to file_sd here: https://github.com/prometheus/prometheus/blob/master/discovery/file/file.go#L195-L211 |
This comment has been minimized.
This comment has been minimized.
|
I am working on this and will be opening a pull request in 2-3 days. |
KalivarapuReshma
referenced this issue
Aug 12, 2017
Closed
Add metric for timestamp of the files file_sd is using. #3063
This comment has been minimized.
This comment has been minimized.
|
I think we can close this now, and close #3063 |
gouthamve
closed this
Dec 25, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedMay 22, 2017
This should work the same way as for the textfile collector.