Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prom2: /delete instead of /series/drop_series #2760

Closed
gouthamve opened this Issue May 24, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@gouthamve
Copy link
Member

gouthamve commented May 24, 2017

Deletes are almost in tsdb [ref] and now I am looking into implementing in Prometheus itself.

We can delete in time-ranges now instead of a full series drop, keeping that in view series/drop_series is a bad endpoint. Should I make a new /delete end-point with start and end as compulsory parameters?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 24, 2017

I think this now opens a bigger discussion. Our API is essentially entirely read-only aside from /series/drop_series, which is currently disabled in 2.0.

Additionally, we'll want to expose DB administrative APIs ultimately like "pause compaction", "resume compaction", "take snapshot". An HTTP API will be our best bet there as well.

I consider deletes an administrative task as well rather than a core functionality of Prometheus. We should think about moving all those into a separate sub-API, which can easily be turned of via flag or blocked via proxies.

Thoughts on this? Separate admin port? Just a different path?

@brian-brazil

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented May 24, 2017

#2173 were my plans for this. TL;DR: Mutating endpoints disabled by flag by default.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 24, 2017

Yes, I'm proposing here to move them all behind a distinct API. That's a) clearer separating purpose and b) more reasonable to implement than having a toggle across random API handlers.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented May 24, 2017

From a security standpoint, having the mutating endpoints under one path would make it easier for users to manage with a reverse proxy.

@gouthamve

This comment has been minimized.

Copy link
Member Author

gouthamve commented Jul 12, 2017

Closed in #2910

@gouthamve gouthamve closed this Jul 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.