Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upProm2: /delete instead of /series/drop_series #2760
Comments
This comment has been minimized.
This comment has been minimized.
|
I think this now opens a bigger discussion. Our API is essentially entirely read-only aside from Additionally, we'll want to expose DB administrative APIs ultimately like "pause compaction", "resume compaction", "take snapshot". An HTTP API will be our best bet there as well. I consider deletes an administrative task as well rather than a core functionality of Prometheus. We should think about moving all those into a separate sub-API, which can easily be turned of via flag or blocked via proxies. Thoughts on this? Separate admin port? Just a different path? |
This comment has been minimized.
This comment has been minimized.
|
#2173 were my plans for this. TL;DR: Mutating endpoints disabled by flag by default. |
This comment has been minimized.
This comment has been minimized.
|
Yes, I'm proposing here to move them all behind a distinct API. That's a) clearer separating purpose and b) more reasonable to implement than having a toggle across random API handlers. |
This comment has been minimized.
This comment has been minimized.
|
From a security standpoint, having the mutating endpoints under one path would make it easier for users to manage with a reverse proxy. |
brian-brazil
added
the
dev-2.0
label
May 25, 2017
This comment has been minimized.
This comment has been minimized.
|
Closed in #2910 |
gouthamve
closed this
Jul 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
gouthamve commentedMay 24, 2017
Deletes are almost in tsdb [ref] and now I am looking into implementing in Prometheus itself.
We can delete in time-ranges now instead of a full series drop, keeping that in view
series/drop_seriesis a bad endpoint. Should I make a new/deleteend-point withstartandendas compulsory parameters?