Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrape_limit in 2.0 should ignore stale values, be instrumented #2770

Closed
brian-brazil opened this Issue May 25, 2017 · 1 comment

Comments

Assignees

@brian-brazil brian-brazil

Labels
dev-2.0
Projects
None yet
Milestone
No milestone
2 participants
@brian-brazil @fabxc
@brian-brazil
Copy link
Member

brian-brazil commented May 25, 2017

The scrape_limit shouldn't include stale markers.

prometheus_target_scrapes_exceeded_sample_limit_total is also not getting incremented.

@brian-brazil brian-brazil added the dev-2.0 label May 25, 2017

@brian-brazil brian-brazil self-assigned this May 29, 2017

brian-brazil added a commit that referenced this issue May 31, 2017

@brian-brazil
Rework sample limit to work for 2.0 
Correctly update reported series.
Increment prometheus_target_scrapes_exceeded_sample_limit_total.
Add back unittests.
Ignore stale markers when calculating sample limit.

Fixes #2770
Loading status checks…
37bc607

@brian-brazil brian-brazil referenced this issue May 31, 2017

Merged

Rework sample limit to work for 2.0 #2787

@fabxc fabxc closed this Jun 6, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.