Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upKubernetes SD; Support external name services #2791
Comments
This comment has been minimized.
This comment has been minimized.
|
How are you envisioning scraping these? This sounds more like a load balancer rather than the individual targets we'd want to scrape. |
This comment has been minimized.
This comment has been minimized.
|
An example might be an external etcd cluster (which ive just grabbed from the clustering guide);
I might setup my service like this
Then the created job would monitor each record there (like the DNS discoverer does) Job: my-external-etcd |
juliusv
added
component/service discovery
kind/enhancement
labels
Jul 8, 2017
brian-brazil
added
the
priority/Pmaybe
label
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
crandles
commented
Jan 25, 2018
•
|
This seems better suited for the service discoverer ( The Would it be viable to simply try resolving a SRV record, and falling back to the externalName entry (instead of trying to resolve its IP)? |
This comment has been minimized.
This comment has been minimized.
|
Just tried this and hoped it would just work but it doesn't. Seems sensible to me to support this. It's IMO the right way to scrape anything outside of a kubernetes cluster. |
This comment has been minimized.
This comment has been minimized.
|
This should be fixed since v2.7.0 by de6f3b6. @discordianfish which version did you try? |
This comment has been minimized.
This comment has been minimized.
|
@simonpasquier I don't think so. I've thought about this a bit more and I don't think an external service type service is generalizable. We still want to perform whitebox monitoring, and we can't generalize that for the same reason we have multiple service discovery mechanisms. Those external systems simply are not part of the same service discovery infrastructure. |
This comment has been minimized.
This comment has been minimized.
|
Those are my thoughts too. Anything outside of k8 will be monitored the ways you'd monitor anything else outside of k8. |
Chronojam commentedJun 1, 2017
This is a proposal to add support for external name services to the Kubernetes SD
Given the following kubernetes service configuration:
and an endpoint discoverer:
I think the Kubernetes SD should create 1 scrape per DNS type
I dont think there is any need to support other types than A/AAAA and SRV (similar to the dns discoverer)?
my.service.example.com:AAAA => 10.0.0.1
my.service.example.com:SRV1 => 10.0.0.1:8080
my.service.example.com:SRV2 => 10.0.0.2:8080
for each endpoint discovered, we should attach a __meta_kubernetes_service_dnstype label with
type ("AAAA"/"SRV")