Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide consul token on UI page #2792

Closed
roman-vynar opened this Issue Jun 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@roman-vynar
Copy link
Contributor

roman-vynar commented Jun 1, 2017

Currently, when you go to Status->Configuration page on UI, you will see that password field in basic_auth section is hidden by <hidden>. However, consul token is not.
For example:

  - job_name: dev
    scheme: https
    basic_auth:
      username: prom
      password: <hidden>
    consul_sd_configs:
      - server: consul.example.com:8500
        token: 140ddb9e-d1a9-45d2-a182-dcb9ed89fed2
        datacenter: us-west-1
        scheme: https
        services: [ consul ]

I would have sent a PR but I couldn't find where 😇

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 1, 2017

https://github.com/prometheus/prometheus/blob/master/config/config.go#L838 should have type Secret if you'd like to fix it. The unittests will need updating too.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.