Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets are not obfuscated on 2.0.0-alpha.2 #2798

Closed
gianrubio opened this Issue Jun 2, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@gianrubio
Copy link

gianrubio commented Jun 2, 2017

What did you do?

Opened the prometheus configuration page

What did you expect to see?

Obfuscated the basic auth password

What did you see instead? Under which circumstances?

The secret are not obfuscated

screen shot 2017-06-02 at 11 08 21

  • Prometheus version:

2.0.0-alpha.2

  • Prometheus configuration file:
- job_name: monitoring/graylog/0
  honor_labels: false
  kubernetes_sd_configs:
  - role: endpoints
  metrics_path: /api/plugins/org.graylog.plugins.metrics.prometheus/metrics
  basic_auth:
    username: |
      prometheus
    password: <hidden>
      534jk5h43klrjdskjfhdskfj
  relabel_configs:
  - action: keep
    source_labels:
    - __meta_kubernetes_service_label_app
    regex: graylog-metrics
  - action: keep
    source_labels:
    - __meta_kubernetes_namespace
    regex: logging
  - action: keep
    source_labels:
    - __meta_kubernetes_endpoint_port_name
    regex: graylog-metrics
  - source_labels:
    - __meta_kubernetes_namespace
    target_label: namespace
  - source_labels:
    - __meta_kubernetes_pod_name
    target_label: pod
  - source_labels:
    - __meta_kubernetes_service_name
    target_label: service
  - source_labels:
    - __meta_kubernetes_service_name
    target_label: job
    replacement: ${1}
  - target_label: endpoint
    replacement: graylog-metrics
@gianrubio

This comment has been minimized.

Copy link
Author

gianrubio commented Jun 2, 2017

Sorry, I generate the k8s secret with break line

$echo 534jk5h43klrjdskjfhdskfj|base64 (wrong)

$echo -n 534jk5h43klrjdskjfhdskfj|base64 (right)

@gianrubio gianrubio closed this Jun 2, 2017

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 2, 2017

This was recently fixed in master, but those commits haven't been brought into 2.0 yet.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.