up healthmetric not work as expected in 2.0 (code bug)

[qinguoan]

                err := sl.scraper.scrape(scrapeCtx, buf)
		cancel()
		var b []byte
		if err == nil {
			b = buf.Bytes()
		} else if errc != nil {
			errc <- err
		}
		// A failed scrape is the same as an empty scrape,
		// we still call sl.append to trigger stale markers.
		if total, added, err = sl.append(b, start); err != nil {
			sl.l.With("err", err).Error("append failed")
			// The append failed, probably due to a parse error.
			// Call sl.append again with an empty scrape to trigger stale markers.
			if _, _, err = sl.append([]byte{}, start); err != nil {
				sl.l.With("err", err).Error("append failed")
			}
		}

		sl.report(start, time.Since(start), total, added, err)

Last line sl.report call may be use nil as parameter err after a scrape error occurred, because scrape error overwrite by append error. But.... append with zero length bytes(scrape failed) will not cause an error.

sorry for my poor English -_-

[brian-brazil]

#2787 fixes this.

[fabxc]

Merged.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.