Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop global default timings #2810
Comments
fabxc
added this to the v2.x milestone
Jun 6, 2017
This comment has been minimized.
This comment has been minimized.
|
I'm against this. For the vast majority of users they should only be setting the global options. By making the per group/scrape_config option the only option we'll see more users shooting themselves in the foot by having more than one interval in a Prometheus. |
This comment has been minimized.
This comment has been minimized.
|
Mh, I'm somewhat okay leaving it I guess. I think it's getting out of hand and increasingly awkward in Alertmanager though. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I'm getting a bit concerned about the AM in this regard. |
fabxc
closed this
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
fabxc commentedJun 6, 2017
•
edited
sWe have global defaults for rule evaluation and scraping. With rule groups coming up, those will also be configurable directly per group.
As it stands, any sufficiently advanced setup wraps the configuration in some sort of templating, be that through Chef and friends or more dynamic things like prometheus-operator. From that perspective, our global defaulting just adds complexity to our code and the final config and rule files are just more complex to read.
We should consider dropping those in Prometheus 2.0 to be explicit that our configs are just the format people should compile down to.
One concern is how this plays into Alertmanager, where we should apply the same rules. It has even more of those global defaults for all the different integrations and is getting really out of hand there. OTOH, it is also a lot more painful there to remove it. (those)