Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port remote APIs to 2.0 #2811

Closed
fabxc opened this Issue Jun 6, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@fabxc
Copy link
Member

fabxc commented Jun 6, 2017

Tracking issue for adding the remote APIs back to dev-2.0. They were removed as the storage interface changed.

@fabxc fabxc added this to the v2.x milestone Jun 6, 2017

@fabxc fabxc added the dev-2.0 label Jun 6, 2017

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 6, 2017

@juliusv you looked into this already. Any progress/blockers so far?

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jun 6, 2017

@fabxc Well, the new storage append interface (using refs) combined with the new staleness handling wrapped around it has made it more complicated and left me confused, so I didn't write any code yet. I might make an attempt this week, but I'll be gone for two weeks (June 11 - 25) afterwards, so it'd be up for grabs during that time if I didn't get to anything yet.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 6, 2017

Are we fine with shipping an initial 2.0 with remote APIs disabled? Seems fine to me TBH, given that they are experimental. Breaking stuff we should get done before is just piling up... so I want to cut down what we can.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Jun 6, 2017

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 6, 2017

I think we need the remote APIs for a 2.0.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 6, 2017

So who is committing to adding these? We are currently committed to:

  • All of storage bugs and stabilization
  • /api/v2
  • CLI changes
  • rule group changes and migration tooling
  • Backup support
  • Deletion support

We only have so much capacity and someone has to handle:

  • Storage migration (docs and/or tooling)
  • Remote APIs
@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jun 6, 2017

Remote APIs

Let me have another look at that and I will give you more of detail about commitment or not by tomorrow.

@tomwilkie

This comment has been minimized.

Copy link
Member

tomwilkie commented Jun 7, 2017

I'll commit to handling this is @juliusv doesn't have time. Remote APIs have been super popular, I think it would be a mistake to not include them in v2.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jun 7, 2017

@tomwilkie That'd be brilliant. I don't think I'm able to commit to full PRs on those before sometime in July, as I'm unavailable during the next two weeks and have plenty of unrelated stuff to take care of. So if you want to go ahead, please do so!

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.