Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMove check for missing __address__ to after relabeling #2819
Comments
brian-brazil
added
the
kind/enhancement
label
Jun 7, 2017
brian-brazil
added a commit
that referenced
this issue
Jun 9, 2017
brian-brazil
referenced this issue
Jun 9, 2017
Merged
Check target labels are valid. Check for address after relabelling. #2828
fabxc
closed this
in
#2828
Jun 16, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedJun 7, 2017
Currently we check for a missing address before relabelling. While this is not something that should come up, we should really be doing this after relabelling in line with when we do all the other checks.