Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upInvalid utf-8 in label value not checked for in text format #2822
Comments
brian-brazil
added
the
kind/bug
label
Jun 8, 2017
This comment has been minimized.
This comment has been minimized.
|
Also, we should check we're doing validation of target labels. |
brian-brazil
added a commit
to prometheus/common
that referenced
this issue
Jun 9, 2017
brian-brazil
referenced this issue
Jun 9, 2017
Merged
Check for invalid utf-8 values in label values. #84
brian-brazil
added a commit
that referenced
this issue
Jun 9, 2017
brian-brazil
referenced this issue
Jun 9, 2017
Merged
Check target labels are valid. Check for address after relabelling. #2828
fabxc
closed this
in
#2828
Jun 16, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedJun 8, 2017
We know that Prometheus catches invalid utf-8 in proto format, but it doesn't appear to do so in text format - which results in invalid data being ingested.
We should ensure we're doing validation on both paths.