Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to modify resolution in graph view #2827

Closed
andrewhowdencom opened this Issue Jun 9, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@andrewhowdencom
Copy link

andrewhowdencom commented Jun 9, 2017

What did you do?

Was showing a colleague how to use Prometheus. We have small blips in the data which are normal, but which you can't see unless you bump the resolution to something like 60s. However in doing this Chrome crashes outright, and firefox complains about a script dying.

What did you expect to see?

Finer data in the graph

What did you see instead? Under which circumstances?

He's dead, jim

Environment

https://hub.docker.com/r/prom/prometheus/

1.7 tag

  • System information:
Linux 4.4.35+ x86_64
  • Prometheus version:
prometheus -version
prometheus, version 1.7.0 (branch: master, revision: bfa37c8ee39d11078662dce16c162a61dccf616c)
  build user:       root@7a6329cc02bb
  build date:       20170607-09:43:48
  go version:       go1.8.3

Some information not included as I don't think it's relevant. Can post anything else you neeed here also.

@AlekSi

This comment has been minimized.

Copy link
Contributor

AlekSi commented Jun 19, 2017

I believe this is due to #2766. 😞

@AlekSi

This comment has been minimized.

Copy link
Contributor

AlekSi commented Jun 19, 2017

That's due to self.params.step being a string at this point. This hack works:

self.params.step = parseInt(self.params.step);

Feel free to work on a better solution if there is no PR from me in a couple of days.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 19, 2017

A PR would be greatly appreciated.

AlekSi added a commit to AlekSi/prometheus that referenced this issue Jun 19, 2017

Parse custom step parameter correctly.
We could use parseDuration, but this will require
more changes.

Fixes prometheus#2827.

brian-brazil added a commit that referenced this issue Jun 19, 2017

@AlekSi

This comment has been minimized.

Copy link
Contributor

AlekSi commented Jun 19, 2017

Would like to see it in 1.7.2.

@AlekSi

This comment has been minimized.

Copy link
Contributor

AlekSi commented Jun 20, 2017

@brian-brazil Should I send a PR for release-1.7? I use that feature in my current work all the time. We upgraded to 1.7 and now it is broken.

@andrewhowdencom

This comment has been minimized.

Copy link
Author

andrewhowdencom commented Jul 10, 2017

If you do @AlekSi can you cc me <3 I also use this regularly. Cool to see that it'd been fixed on main though!

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented Jul 10, 2017

Please do!

AlekSi added a commit to AlekSi/prometheus that referenced this issue Jul 10, 2017

juliusv added a commit that referenced this issue Jul 10, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.