Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `/-/healthy` and `/-/ready` endpoints #2831
Comments
This comment has been minimized.
This comment has been minimized.
|
From the discussion in prometheus/pushgateway#105 , I'd say what you want here is a In other words: Prometheus should bind to Prometheus should start responding 200 to |
beorn7
changed the title
Add /-/health endpoint
Add `/-/healthy` and `/-/ready` endpoints
Jun 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Ah nice, yes that totally makes sense |
This comment has been minimized.
This comment has been minimized.
yonkeltron
commented
Jul 5, 2017
|
Just wanted to throw in my two cents for this one as it would be awesome to have this for Kubernetes to use as well. |
brian-brazil
added
kind/enhancement
component/ui
low hanging fruit
help wanted
and removed
help wanted
labels
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
|
@gouthamve I just saw you pinged me on IRC about this. I think all my thoughts around this have already been dumped into my last comment above. Please let me know what you are missing, and I'll try to go into more details where needed. |
This comment has been minimized.
This comment has been minimized.
|
Hi, I have been working on this on my local. I have arrived at a simple working solution. I think I could send a PR before end of week. If nobody else is working on this I would like to claim the issue. |
This comment has been minimized.
This comment has been minimized.
|
Sure @emluque, looking forward to the PR! Incase you get stuck somewhere, feel free to hit us up on IRC or comment here. EDIT: Hmm, I am not able to assign you to this issue, sorry. Just comment below if you stop working on this. |
gouthamve
assigned
gouthamve
and unassigned
gouthamve
Jul 26, 2017
emluque
referenced this issue
Jul 26, 2017
Merged
Add `/-/healthy` and `/-/ready` endpoints #2831 #2997
grobie
added a commit
that referenced
this issue
Aug 7, 2017
This comment has been minimized.
This comment has been minimized.
SimenB
commented
Aug 15, 2017
|
#2997 is merged, should this be closed? |
This comment has been minimized.
This comment has been minimized.
|
Resolved with #2997. |
grobie
closed this
Aug 15, 2017
This comment has been minimized.
This comment has been minimized.
julianvmodesto
commented
Oct 5, 2017
|
Is it possible to backport this to 1.7.x? Related to coreos/prometheus-operator#658 |
This comment has been minimized.
This comment has been minimized.
|
This is part of the 1.x line of Prometheus. It will in fact be released tomorrow (if nothing goes wrong). It will be 1.8.0, however, as this is a new feature and not a bug fix. |
julianvmodesto
referenced this issue
Oct 5, 2017
Closed
update liveness and readiness probes for Prometheus 1.8.x #669
YouriT
referenced this issue
Dec 12, 2017
Closed
[prometheus] use other endpoints for readiness/liveness #3000
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
discordianfish commentedJun 10, 2017
•
edited
Prometheus should provide an health endpoint which returns 200 if prometheus is ready to response to queries (recovery is done etc).
The officially recommendation on high availability is to run two instances behind a load balance. In such scenario we need a health endpoint to avoid hitting a prometheus server that got restarted and isn't ready to serve traffic.