Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMove remote.proto into its own directory #2845
Comments
This comment has been minimized.
This comment has been minimized.
|
+1, also see #2821 (comment) |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil In #2821 you proposed a single directory listing our protos. The general trend in Go seems to be to have I'm open to either but would like to hear more arguments/opinions. Can we agree to avoid sharing partial proto types across repositories, i.e. not have AMs silence matcher import its |
This comment has been minimized.
This comment has been minimized.
|
I'm not too pushed either way on sharing. |
This comment has been minimized.
This comment has been minimized.
|
The dev-2.0 branch has a prompb directory for these. |
brian-brazil
added
priority/P3
help wanted
and removed
help wanted
labels
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Closed by #2850 |
tomwilkie
closed this
Aug 3, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
brian-brazil commentedJun 15, 2017
Currently remote.proto is sitting in with the remote read/write code, which means any adapters using it end up pulling in some Prometheus code which they really shouldn't.
This was done initially to get things going, but we should find a better place to put our public protos long term.