Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remote.proto into its own directory #2845

Closed
brian-brazil opened this Issue Jun 15, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Jun 15, 2017

Currently remote.proto is sitting in with the remote read/write code, which means any adapters using it end up pulling in some Prometheus code which they really shouldn't.

This was done initially to get things going, but we should find a better place to put our public protos long term.

@tomwilkie

This comment has been minimized.

Copy link
Member

tomwilkie commented Jun 15, 2017

+1, also see #2821 (comment)

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jun 16, 2017

@brian-brazil In #2821 you proposed a single directory listing our protos. The general trend in Go seems to be to have pkg/remote/remotepb for example to address the problem or unnecessary imports. That's how AM does it.
I can see how a single dir makes it easier to find. But it kind of messes with hierarchical package structure.

I'm open to either but would like to hear more arguments/opinions.

Can we agree to avoid sharing partial proto types across repositories, i.e. not have AMs silence matcher import its LabelMatcher proto from prometheus/prometheus or share mundane stuff like the LabelPair tuple?

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jun 16, 2017

I'm not too pushed either way on sharing.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jul 14, 2017

The dev-2.0 branch has a prompb directory for these.

@tomwilkie

This comment has been minimized.

Copy link
Member

tomwilkie commented Aug 3, 2017

Closed by #2850

@tomwilkie tomwilkie closed this Aug 3, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.