Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose direct TSDB querying in v2 API #2849
Comments
This comment has been minimized.
This comment has been minimized.
|
Wouldn't that basically be the remote read endpoint? |
This comment has been minimized.
This comment has been minimized.
|
To a degree, sure. But I want to have it focused and extensible on TSDBs primitives, which are lower level than the remote-read path. I want to provide access to the on-disk/in-mem chunks as they are for example. |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure we should be offering that level of detail via the API that can be used by the average user, it sounds like something that belongs more in promtool. |
This comment has been minimized.
This comment has been minimized.
|
Yep, but promtool would be needing the APIs. Also, given this is an admin API, I think it is fine. |
This comment has been minimized.
This comment has been minimized.
|
As it's get only, I wouldn't necessarily put it under admin/ – but would if not otherwise acceptable. |
fabxc commentedJun 16, 2017
I would like the v2 API to expose a minimal layer to query the TSDB directly on top of the admin actions we expose. Any objections or concerns around this?
@brian-brazil @gouthamve