Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose direct TSDB querying in v2 API #2849

Open
fabxc opened this Issue Jun 16, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@fabxc
Copy link
Member

fabxc commented Jun 16, 2017

I would like the v2 API to expose a minimal layer to query the TSDB directly on top of the admin actions we expose. Any objections or concerns around this?

@brian-brazil @gouthamve

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 16, 2017

Wouldn't that basically be the remote read endpoint?

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 16, 2017

To a degree, sure. But I want to have it focused and extensible on TSDBs primitives, which are lower level than the remote-read path. I want to provide access to the on-disk/in-mem chunks as they are for example.
There's interesting tooling to be built on top of that but it might not be suitable for a simple gateway implementation.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 16, 2017

I'm not sure we should be offering that level of detail via the API that can be used by the average user, it sounds like something that belongs more in promtool.

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Jun 16, 2017

Yep, but promtool would be needing the APIs. Also, given this is an admin API, I think it is fine.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 16, 2017

As it's get only, I wouldn't necessarily put it under admin/ – but would if not otherwise acceptable.
I wasn't looking at promtool use cases per se. The reason why this couldn't go into external tooling is because that doesn't give us access to in-memory blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.