Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add commenting to promQL #2855

Closed
virusdave opened this Issue Jun 16, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@virusdave
Copy link

virusdave commented Jun 16, 2017

Feature request: Add some means of commenting or disabling portions of a query in promql.

This is especially useful when using the /graph playground to explore and compose queries. Currently one almost needs to keep a separate text file or state somewhere to compose query snippets. It would be very helpful if i could "comment out" portions of a query while trying to construct a query or debug one that's not working as expected.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 16, 2017

I don't think comments within a promql expression is something that we should support, I can see it causing confusion.

@virusdave

This comment has been minimized.

Copy link
Author

virusdave commented Jun 16, 2017

Apparently this already exists: # will comment until end-of-line.

@virusdave virusdave closed this Jun 16, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.