Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd AssumeRole to EC2 discovery #2877
Comments
This comment has been minimized.
This comment has been minimized.
|
I have created a pull request for this #2895 |
brian-brazil
added
the
component/service discovery
label
Jul 7, 2017
brian-brazil
added
priority/P3
kind/enhancement
labels
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
|
This can be closed now, I think? |
brian-brazil
closed this
Oct 24, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
jubagarie commentedJun 26, 2017
It would be nice to add the "AssumeRole" feature to the EC2 discovery. It would allow a Prometheus node to target instances in several AWS accounts easily.
It may not be always relevant to have one Prometheus instance per account as some of them are containing very few nodes or are preproduction environments.
I expected the "profile" key in the EC2 discovery configuration to allow this, but it doesn't seem to be working as expected. Using any valid or invalid value (e.g. existing profile or not in ~/.aws/config) behaves the same way : only the EC2 instances running in the same AWS account as the Prometheus instance are targeted.
Environment
System information:
Linux 3.16.0-4-amd64 x86_64
Prometheus version:
prometheus, version 1.7.1 (branch: master, revision: 3afb3ff)
build user: root@0aa1b7fc430d
build date: 20170612-11:44:05
go version: go1.8.3