Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssumeRole to EC2 discovery #2877

Closed
jubagarie opened this Issue Jun 26, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@jubagarie
Copy link

jubagarie commented Jun 26, 2017

It would be nice to add the "AssumeRole" feature to the EC2 discovery. It would allow a Prometheus node to target instances in several AWS accounts easily.

It may not be always relevant to have one Prometheus instance per account as some of them are containing very few nodes or are preproduction environments.

I expected the "profile" key in the EC2 discovery configuration to allow this, but it doesn't seem to be working as expected. Using any valid or invalid value (e.g. existing profile or not in ~/.aws/config) behaves the same way : only the EC2 instances running in the same AWS account as the Prometheus instance are targeted.

Environment

  • System information:
    Linux 3.16.0-4-amd64 x86_64

  • Prometheus version:
    prometheus, version 1.7.1 (branch: master, revision: 3afb3ff)
    build user: root@0aa1b7fc430d
    build date: 20170612-11:44:05
    go version: go1.8.3

@jamiemoore

This comment has been minimized.

Copy link
Contributor

jamiemoore commented Jul 4, 2017

I have created a pull request for this #2895

@diurnalist

This comment has been minimized.

Copy link
Contributor

diurnalist commented Oct 24, 2017

This can be closed now, I think?

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.