Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPrometheus config rendered from struct no longer parses #2899
Comments
brian-brazil
added
the
kind/bug
label
Jul 4, 2017
tcolgate
referenced this issue
Jul 4, 2017
Merged
Stricter Relabel Config Checking for Labeldrop/keep #2510
gouthamve
pushed a commit
to gouthamve/prometheus
that referenced
this issue
Jul 5, 2017
gouthamve
referenced this issue
Jul 5, 2017
Merged
Make sure rendering config produces valid config #2904
fabxc
closed this
in
#2904
Jul 5, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tcolgate commentedJul 4, 2017
5c89cec breaks configs rendered from the internal config struct (yeah, I know it's nasty, but we build prom configs automatically and we vendor prom to support it).
The above change beaks because the config renders as
either source_labels should include "omitempty", or the above sourcelabel check should be updated to something which parses with nil vs empty slice (e.g. len())
What did you do?
Attempted to run prometheus master with a configuration from our config management tool.
What did you expect to see?
Prometheus accept the configuration and start.
What did you see instead? Under which circumstances?
prometheus fails with ```time="2017-07-04T12:10:18Z" level=error msg="Error loading config: couldn't load configuration (-config.file=/etc/prometheus/config.yaml): labeldrop action requires only 'regex', and no other fields" source="main.go:160"