Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench.go imports "testing", pollutes global flag namespace #2920

Closed
tomwilkie opened this Issue Jul 7, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomwilkie @fabxc
@tomwilkie
Copy link
Member

tomwilkie commented Jul 7, 2017

promql/bench.go imports testing for a non-test module, which means anyone who imports the promql package (cortex) gets all the test flags in non-test binaries.
@fabxc

This comment has been minimized.

Sign in to view
Copy link
Member

fabxc commented Jul 7, 2017

I think I took a stab at this a couple of times and it's just hard to get out.
The answer is ultimately to not use the global flag set for your applications – which you should never be doing anyway ;)

@tomwilkie tomwilkie referenced this issue Jul 7, 2017

Merged

Add _test.go suffix to promql/bench.go, split test.go in to two. #2921

@tomwilkie

This comment has been minimized.

Sign in to view
Copy link
Member Author

tomwilkie commented Jul 7, 2017

Rgr. I think this simple fix might do the trick, if people don't find it to distasteful.

@fabxc fabxc closed this in #2921 Jul 10, 2017

temoto added a commit to temoto/vender that referenced this issue Dec 4, 2018

@temoto
clean test flags garbage from cmd -help 
Found same issues:
- prometheus/prometheus#2920
- hashicorp/vault#3745
540fbeb

temoto added a commit to temoto/vender that referenced this issue Feb 11, 2019

@temoto
clean test flags garbage from cmd -help 
Found same issues:
- prometheus/prometheus#2920
- hashicorp/vault#3745
f765605
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.