Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus 2.0 dynamically linked on Linux #2922

Closed
brian-brazil opened this Issue Jul 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@brian-brazil
Copy link
Member

brian-brazil commented Jul 7, 2017

When I build the dev-2.0 branch via make, I'm getting a dynamically linked binary. This should be static.

We should figure out what's going wrong.

@brian-brazil brian-brazil added the dev-2.0 label Jul 7, 2017

@brian-brazil brian-brazil added this to the v2.x milestone Jul 7, 2017

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Jul 7, 2017

Heres why: prometheus/promu#60

I tried to hack this in: #2460 but closed it.

From @mxinden's comment on the linked issue, I think to build static binaries, we need to have write access to $GOROOT. Alternatively we could use docker, but that looks like a harder requirement.

The same happens to 1.0 also, btw.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jul 7, 2017

We've already got a bug for that, so no need to keep this one open. Sounds like it'll be fixed in Go 1.10.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.