Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure SD mechanisms are resilient to failure #2924

Open
brian-brazil opened this Issue Jul 8, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
component/service discovery help wanted kind/enhancement priority/P2
Projects
None yet
Milestone
No milestone
2 participants
@brian-brazil @gouthamve
@brian-brazil
Copy link
Member

brian-brazil commented Jul 8, 2017 •
edited

There have been a few reports of all/many targets being removed when a SD failed in some way.

We should keep using the old target information when a SD fails. Confirm this is what we're doing inside Prometheus, and within each SD mechanism (i.e. SD mechanisms should hard fail rather than returning partial results).

@brian-brazil brian-brazil added the component/service discovery label Jul 8, 2017

@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member Author

brian-brazil commented Jul 14, 2017

#2924 is an example of this.

@brian-brazil brian-brazil added priority/P2 kind/enhancement labels Jul 14, 2017

@grobie grobie referenced this issue Jul 20, 2017

Closed

DNS SD: If all targets disappear, Prometheus keeps them. #2799

@gouthamve gouthamve added the help wanted label Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.