Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Discovery meta issue #2935

Open
gouthamve opened this Issue Jul 11, 2017 · 11 comments

Comments

Projects
None yet
6 participants
@gouthamve
Copy link
Member

gouthamve commented Jul 11, 2017

Docs:

Others:

  • Evaluate integration testing approaches and float proposal in -dev
  • Mark issues with difficulty so as to give contributors an easy way to start
  • Tooling to take SD interface and have an easy way to build file_sd sidecars
  • Some solid documentation of what makes in and what doesn't
  • Contact CNCF about the accounts on the several providers

In case I missed anything, please comment below and I will update the list.

/cc @juliusv @grandbora @TheTincho @cstyan @Verolop

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 11, 2017

I was thinking more a README for both the docs.

@gouthamve

This comment has been minimized.

Copy link
Member Author

gouthamve commented Jul 11, 2017

@cstyan

This comment has been minimized.

Copy link
Contributor

cstyan commented Jul 12, 2017

do we want to discuss other issue labels now as well? re: priority/accepted feature requests

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 12, 2017

Priority we have, it's just unused right now and Pmaybe is unaccepted requests. I believe the question was more around indicating size and suitability for new contributors.

@cstyan

This comment has been minimized.

Copy link
Contributor

cstyan commented Jul 12, 2017

👍 cool, just checked the labels and saw those were there. Should have checked before, but from the discussion in the SD meeting it sounded like those labels didn't already exist.

A size/easy to implement label would absolutely be nice to have :)

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jul 12, 2017

@cstyan Yep, @gouthamve also started a separate thread on the ML about issue labeling in general: https://groups.google.com/forum/#!topic/prometheus-developers/FdbNCX3FFRc

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 13, 2017

#2943 has my part of the SD docs

@cstyan

This comment has been minimized.

Copy link
Contributor

cstyan commented Oct 16, 2017

what's the status here? anything I can help with?

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Feb 7, 2018

@gouthamve I think you can mark most of these as done or maybe even close as there are other issues covering all these I think?

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Aug 1, 2018

With @cstyan's work on the SD adapter and his blog post being published, I feel too that this issue can be closed. @gouthamve?

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Aug 12, 2018

I would say good to close as well

for SD we have an issue on prombench
prometheus/prombench#133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.