Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk encoding affects query results #2965

Closed
AlekSi opened this Issue Jul 18, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@AlekSi
Copy link
Contributor

AlekSi commented Jul 18, 2017

Please see this test: https://github.com/AlekSi/prometheus/blob/ec68e9722a8b740ee9631dc4ae58398f0f42f3a4/promql/range_test.go I expect it to return 21 values independent of chunk encoding. @SuperQ confirmed at IRC that query results should not be affected by storage. But they are: https://travis-ci.org/AlekSi/prometheus/builds/254887870

This test fails with both current master and v1.7.1.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 18, 2017

@beorn7 beorn7 self-assigned this Jul 18, 2017

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jul 20, 2017

Thanks @AlekSi for the perfect bug report including test.

This is intriguing, if the timestamp is off by 1ms, everything works as expected. I guess the chunk iterator in encoding v2 gets a hiccup if you hit a sample's timestamp precisely and then skips the next data point.

I'll try to nail this down in a unit test in the storage layer itself.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.