Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChunk encoding affects query results #2965
Comments
brian-brazil
added
component/local storage
kind/bug
labels
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
beorn7
self-assigned this
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks @AlekSi for the perfect bug report including test. This is intriguing, if the timestamp is off by 1ms, everything works as expected. I guess the chunk iterator in encoding v2 gets a hiccup if you hit a sample's timestamp precisely and then skips the next data point. I'll try to nail this down in a unit test in the storage layer itself. |
beorn7
added a commit
that referenced
this issue
Jul 21, 2017
beorn7
closed this
in
ea5e7ea
Jul 21, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
AlekSi commentedJul 18, 2017
Please see this test: https://github.com/AlekSi/prometheus/blob/ec68e9722a8b740ee9631dc4ae58398f0f42f3a4/promql/range_test.go I expect it to return 21 values independent of chunk encoding. @SuperQ confirmed at IRC that query results should not be affected by storage. But they are: https://travis-ci.org/AlekSi/prometheus/builds/254887870
This test fails with both current master and v1.7.1.