Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote storage blocks shutdown if other end is having issues #2972

Closed
tomwilkie opened this Issue Jul 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@tomwilkie
Copy link
Member

tomwilkie commented Jul 19, 2017

From @brian-brazil in #2847:

The remote write generally doesn't seem to like the other end having issues, such as being down for 5+ minutes. In this scenario, it also blocks shutdown.

I propose we have a timeout (1 min) to allow samples to flush, and otherwise exit uncleanly. WDYT?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 19, 2017

That sounds okay in principle. That probably should be flag controlled, and be shorter in line with the k8 shutdown. I'd say 20-25s, given k8 is 30s.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.