Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemote storage blocks shutdown if other end is having issues #2972
Comments
This comment has been minimized.
This comment has been minimized.
|
That sounds okay in principle. That probably should be flag controlled, and be shorter in line with the k8 shutdown. I'd say 20-25s, given k8 is 30s. |
This was referenced Jan 29, 2018
sevagh
referenced this issue
May 11, 2018
Closed
Prometheus poller not handling remote storage failures elegantly #4159
tomwilkie
referenced this issue
May 23, 2018
Merged
Only give remote queues 1 minute to flush samples on shutdown. #4187
tomwilkie
closed this
in
#4187
May 29, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tomwilkie commentedJul 19, 2017
•
edited
From @brian-brazil in #2847:
I propose we have a timeout (1 min) to allow samples to flush, and otherwise exit uncleanly. WDYT?