Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSome development dependencies are not versioned #3022
Comments
This comment has been minimized.
This comment has been minimized.
|
Those dependencies have disto and arch specific non-Go dependencies themselves, so I don't think it's possible to vendor them. |
This comment has been minimized.
This comment has been minimized.
|
Well, |
fabxc
added
dev-2.0
kind/cleanup
priority/Pmaybe
and removed
dev-2.0
labels
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AlekSi commentedAug 3, 2017
What did you do?
What did you expect to see?
What did you see instead? Under which circumstances?
This script uses https://github.com/gogo/protobuf and https://github.com/grpc-ecosystem/grpc-gateway from GOPATH, they are not vendored. This means that every contributor who touches that part (like me) will create a different version of generated files. The changes are not trivial.
I propose to vendor those dependencies and use them. What do you think?