Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some development dependencies are not versioned #3022

Open
AlekSi opened this Issue Aug 3, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@AlekSi
Copy link
Contributor

AlekSi commented Aug 3, 2017

What did you do?

git checkout dev-2.0
scripts/genproto.sh
git status

What did you expect to see?

nothing to commit, working tree clean

What did you see instead? Under which circumstances?

Changes not staged for commit:
	modified:   documentation/dev/api/swagger.json
	modified:   prompb/rpc.pb.go
	modified:   prompb/rpc.pb.gw.go
	modified:   prompb/types.pb.go

This script uses https://github.com/gogo/protobuf and https://github.com/grpc-ecosystem/grpc-gateway from GOPATH, they are not vendored. This means that every contributor who touches that part (like me) will create a different version of generated files. The changes are not trivial.

I propose to vendor those dependencies and use them. What do you think?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Aug 3, 2017

Those dependencies have disto and arch specific non-Go dependencies themselves, so I don't think it's possible to vendor them.

@AlekSi

This comment has been minimized.

Copy link
Contributor Author

AlekSi commented Aug 7, 2017

Well, protoc version is checked by genproto.sh script. What else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.