Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.json in dev-2.0 is broken #3030

Closed
AlekSi opened this Issue Aug 7, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
dev-2.0 kind/cleanup
Projects
None yet
Milestone
No milestone
3 participants
@AlekSi @grobie @fabxc
@AlekSi
Copy link
Contributor

AlekSi commented Aug 7, 2017

Please look there: https://github.com/prometheus/prometheus/blob/dev-2.0/vendor/vendor.json Search for 84bc9597164f671c0130543778228928d6865c5c. You will see it for too many import paths. This commit exists in cockroachdb repository (cockroachdb/cockroach@84bc959), but in https://github.com/petermattis/goid, for example. Notice also that those origin paths contain /vendor/. I can only guess that old version of Go or old version of govendor was used to update vendor.json.

The end result is that govendor sync fails with Go 1.8.3 and govendor 1.0.8.

Refs #3022.

@AlekSi AlekSi referenced this issue Aug 7, 2017

Open

Dependency dependency (transitive?) #348

@fabxc fabxc added dev-2.0 kind/cleanup labels Aug 8, 2017

@fabxc fabxc referenced this issue Aug 11, 2017

Closed

Switch to go-kit log #3061

@grobie

This comment has been minimized.

Sign in to view
Copy link
Member

grobie commented Nov 12, 2017

Fixed in #3400.

@grobie grobie closed this Nov 12, 2017

@simonpasquier simonpasquier referenced this issue Oct 24, 2018

Merged

Fix errors in the vendor/ directory #4781

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.