Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemote Storage reads based on time range in local storage or not #3041
Comments
This comment has been minimized.
This comment has been minimized.
|
This needs to be configurable, as not all remote adapters are remote storage. |
This comment has been minimized.
This comment has been minimized.
|
We could quite easily add a "low water mark" field to the remote read config. It would be a duration, and we would only read from remotes it the range is outside of now - low water mark. Alternatively we could use the configured retention period, although I think having a separate duration might be more useful for cases where you've blown your prometheus data away. WDYT? |
This comment has been minimized.
This comment has been minimized.
|
We need to know when the local storage was initilised/oldest timestamp, and then use whichever is newer of that and the retention period. Plus some slack. This can't be configured as a simple option, as the range changes over time. |
Thib17
added a commit
to Thib17/prometheus
that referenced
this issue
Aug 23, 2017
Thib17
referenced this issue
Aug 23, 2017
Closed
[Draft] Remote storage reads based on oldest timestamp in local storage #1
This comment has been minimized.
This comment has been minimized.
|
Hello, |
This comment has been minimized.
This comment has been minimized.
Either would work, oldest chunk is probably wisest. That would need to be plumbed through from the |
This was referenced Aug 30, 2017
gouthamve
closed this
in
prometheus/tsdb#134
Sep 25, 2017
brian-brazil
reopened this
Sep 25, 2017
brian-brazil
closed this
in
#3129
Oct 18, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
wleese commentedAug 9, 2017
What did you do?
Configured Prometheus with remote storage to push data to InfluxDB (purely for long retention purposes)
What did you expect to see?
Some kind of 'intelligent' awareness of where to query data from.
What did you see instead? Under which circumstances?
All read queries are simply pushed to remote storage
1.7.1
It would seem to me that currently a common setup would be:
[ Prometheus ] -> [ Remote Storage Adapter ] -> [ InfluxDB ]
Where InfluxDB or any other solution would purely be used when wanting more data than just Prometheus' retention period.
A truly intelligent would no doubt be hard to create, but if this setup is indeed common, it could be valuable to introduce a setting to make Prometheus aware of being run in such a setup, allowing queries within Prometheus' retention range to be solely handled by Prometheus.
A simple workaround (?) would be to have an extra setting in the Remote Storage adapter that returns an empty data set if the query time range is < than $config_file_setting