Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach target labels at scrape time #3047

Closed
fabxc opened this Issue Aug 10, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@fabxc
Copy link
Member

fabxc commented Aug 10, 2017

Currently we are wrapping appends to attach target labels – so right before insertion into the storage. That causes us to first allocate label sets when we first see the target and then creating new label sets, which causes memory spikes when many targets appear at once.

If we can pull that logic deeper in, we can directly build the correct label set.
Slightly less nice abstraction, but probably worth it.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.