Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upValidation for all SD configs #3067
Comments
This comment has been minimized.
This comment has been minimized.
|
DIBS There is no pending PR for this right? |
gouthamve
added
the
help wanted
label
Jan 18, 2018
This comment has been minimized.
This comment has been minimized.
|
@krasi-georgiev Are you still working on it? if not can I take it over? |
This comment has been minimized.
This comment has been minimized.
|
@serathius , nope you can go ahead, I got lost in other PR's |
This comment has been minimized.
This comment has been minimized.
|
@gouthamve I added validation based on prometheus documentation, it should be enough to eliminate case in #3066 |
This comment has been minimized.
This comment has been minimized.
|
@gouthamve what do you think of closing this issue? The scope being unclear, it is impossible to declare that it is done. |
This comment has been minimized.
This comment has been minimized.
|
I see that the consul |
gouthamve commentedAug 14, 2017
There is no validation for some SD configurations which might lead to issues like: #3066 The KubernetesSD config is a good example where validation happens: https://github.com/prometheus/prometheus/blob/master/config/config.go#L1049-L1065
This should be done for every SD mechanism.