Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for all SD configs #3067

Open
gouthamve opened this Issue Aug 14, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@gouthamve
Copy link
Member

gouthamve commented Aug 14, 2017

There is no validation for some SD configurations which might lead to issues like: #3066 The KubernetesSD config is a good example where validation happens: https://github.com/prometheus/prometheus/blob/master/config/config.go#L1049-L1065

This should be done for every SD mechanism.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Sep 8, 2017

DIBS

There is no pending PR for this right?

@serathius

This comment has been minimized.

Copy link
Contributor

serathius commented Mar 1, 2018

@krasi-georgiev Are you still working on it? if not can I take it over?

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Mar 1, 2018

@serathius , nope you can go ahead, I got lost in other PR's

@serathius

This comment has been minimized.

Copy link
Contributor

serathius commented Mar 7, 2018

@gouthamve I added validation based on prometheus documentation, it should be enough to eliminate case in #3066
Should we consider more aggressive version? Writing full rules for openstack optional flags looks impossible without breaking someone.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Sep 4, 2018

@gouthamve what do you think of closing this issue? The scope being unclear, it is impossible to declare that it is done.

@palash25

This comment has been minimized.

Copy link
Contributor

palash25 commented Feb 19, 2019

I see that the consul SDConfig doesn't have any other validations except for the Server field, are any other validations required for other fields such as Password or Token? cc @gouthamve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.