Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate `/targets` to use `/api/v1/targets` as the backend #3069
Comments
RichiH
added
component/ui
kind/cleanup
low hanging fruit
labels
Aug 14, 2017
RichiH
changed the title
Migrate `targets` to use `/api/v1/targets` on the backend
Migrate `/targets` to use `/api/v1/targets` as the backend
Aug 14, 2017
This comment has been minimized.
This comment has been minimized.
|
I'm against doing this partially.
We started implementing API endpoints for things visible in the UI a while
ago to support building UIs purely against the API. But we shouldn't
attempt migrating single pages to fetch data via JS while others remain
being rendered at the server.
That would just make our JS code more messy than it already is. Probably
needs a new UI like Alertmanager.
…On Mon, Aug 14, 2017 at 3:54 PM Richard Hartmann ***@***.***> wrote:
Very low prio, but targets should use /api/v1/targets instead of dumping
HTML at the user.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3069>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuA8jr5pWjr9KwtXuRpr1AELpN4bN2Tks5sYFGtgaJpZM4O2ZiG>
.
|
This comment has been minimized.
This comment has been minimized.
|
Same. Stuart, Andrey and I talked about a new UI already. Plans for this
have been around for a long time.
On Mon, Aug 14, 2017 at 4:02 PM Fabian Reinartz <notifications@github.com>
wrote:
… I'm against doing this partially.
We started implementing API endpoints for things visible in the UI a while
ago to support building UIs purely against the API. But we shouldn't
attempt migrating single pages to fetch data via JS while others remain
being rendered at the server.
That would just make our JS code more messy than it already is. Probably
needs a new UI like Alertmanager.
On Mon, Aug 14, 2017 at 3:54 PM Richard Hartmann ***@***.***
>
wrote:
> Very low prio, but targets should use /api/v1/targets instead of dumping
> HTML at the user.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#3069>, or mute the
thread
> <
https://github.com/notifications/unsubscribe-auth/AEuA8jr5pWjr9KwtXuRpr1AELpN4bN2Tks5sYFGtgaJpZM4O2ZiG
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3069 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANaL-OovY2vIBlUGdw_dpuXrhQRX2lks5sYFMtgaJpZM4O2ZiG>
.
|
This comment has been minimized.
This comment has been minimized.
|
Valid point; "migrate everything under /status once the new status APIs are done" sounds saner. |
brian-brazil
added
the
priority/P3
label
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RichiH commentedAug 14, 2017
Very low prio, but
targetsshould use/api/v1/targetsinstead of dumping HTML at the user.