Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache labelset->fingerprint lookups #307

Closed
juliusv opened this Issue Jun 20, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@juliusv
Copy link
Member

juliusv commented Jun 20, 2013

This becomes relevant for large labelsets, even if they only map to a single timeseries: looking up the fingerprints for the labelset then takes the majority of time (e.g. 70ms of 76ms total query time).

Every time we do this lookup, we go out to both disk and memory. We should probably cache these lookups in memory too.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented Jul 22, 2015

Not applicable anymore to how we do things in the query layer nowadays. Closing.

@juliusv juliusv closed this Jul 22, 2015

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#307 from prometheus/fish/update-archite…
…cture-diagram

Update architecture diagram
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.