Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_auth support in marathon_sd_config #3090

Closed
jaydipdave opened this Issue Aug 18, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
component/service discovery kind/enhancement priority/P3
Projects
None yet
Milestone
No milestone
3 participants
@jaydipdave @rabun788 @brian-brazil
@jaydipdave
Copy link

jaydipdave commented Aug 18, 2017

What did you do?
Well, trying to configure Marathon monitoring in Prometheus. Marathon does not support built in authentication, so obviously someone has to use basic_auth to protect Marathon/Mesos. We did the same.

What did you expect to see?
There is already a way to support basic auth for other modules, then why shouldn't we implement that for marathon_sd_config? Copy/Past stuff!! :)

  • Prometheus version:

    prometheus, version 1.7.1 (branch: master, revision: 3afb3ff)
    build user: root@0aa1b7fc430d
    build date: 20170612-11:44:05
    go version: go1.8.3

@brian-brazil brian-brazil added component/service discovery kind/enhancement priority/P3 labels Aug 21, 2017

@rabun788

This comment has been minimized.

Sign in to view
Copy link

rabun788 commented Sep 12, 2017

👍

@plaflamme plaflamme referenced this issue Mar 25, 2018

Merged

Use common HTTPClientConfig for marathon_sd configuration #4009

plaflamme added a commit to plaflamme/prometheus that referenced this issue Mar 25, 2018

@plaflamme
Use common HTTPClientConfig for marathon_sd configuration 
This adds support for basic authentication which closes prometheus#3090

The support for specifying the client timeout was removed as discussed in prometheus/common#123. Marathon was the only sd mechanism doing this and configuring the timeout is done through `Context`.
a8c7d15

@brian-brazil brian-brazil closed this in #4009 Apr 5, 2018

brian-brazil added a commit that referenced this issue Apr 5, 2018

@plaflamme @brian-brazil
Use common HTTPClientConfig for marathon_sd configuration (#4009) 
This adds support for basic authentication which closes #3090

The support for specifying the client timeout was removed as discussed in prometheus/common#123. Marathon was the only sd mechanism doing this and configuring the timeout is done through `Context`.

DC/OS uses a custom `Authorization` header for authenticating. This adds 2 new configuration properties to reflect this.

Existing configuration files that use the bearer token will no longer work. More work is required to make this backwards compatible.
Loading status checks…
2aba238

This was referenced Apr 10, 2018

Closed
Closed

sipian pushed a commit to sipian/prometheus that referenced this issue May 18, 2018

@plaflamme @brian-brazil
Use common HTTPClientConfig for marathon_sd configuration (prometheus… 
…#4009)

This adds support for basic authentication which closes prometheus#3090

The support for specifying the client timeout was removed as discussed in prometheus/common#123. Marathon was the only sd mechanism doing this and configuring the timeout is done through `Context`.

DC/OS uses a custom `Authorization` header for authenticating. This adds 2 new configuration properties to reflect this.

Existing configuration files that use the bearer token will no longer work. More work is required to make this backwards compatible.
Signed-off-by: sipian <cs15btech11019@iith.ac.in>
e54630b

gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 1, 2018

@plaflamme @gouthamve
Use common HTTPClientConfig for marathon_sd configuration (prometheus… 
…#4009)

This adds support for basic authentication which closes prometheus#3090

The support for specifying the client timeout was removed as discussed in prometheus/common#123. Marathon was the only sd mechanism doing this and configuring the timeout is done through `Context`.

DC/OS uses a custom `Authorization` header for authenticating. This adds 2 new configuration properties to reflect this.

Existing configuration files that use the bearer token will no longer work. More work is required to make this backwards compatible.
ebb4016
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.