Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus 2.0: remote storage configuration is ignored #3095

Closed
AlekSi opened this Issue Aug 20, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@AlekSi
Copy link
Contributor

AlekSi commented Aug 20, 2017

github.com/prometheus/prometheus/config.QueueConfig values are ignored in dev-2.0 branch. This structure is duplicated by github.com/prometheus/prometheus/storage/remote.QueueManagerConfig which is not configurable.

In #2552 @brian-brazil wrote

I'd suggest hardcoding to reasonable sane values, and seeing when someone wants it changed what their use case is.

I want to increase max_samples_per_send because 100 samples per insert is too small value for PromHouse and ClickHouse.

Also, I would like to see QueueManagerConfig removed – that's one of the places where Prometheus duplicates the same code in different packages.

I can work on it if you are ok with it.

/cc @tomwilkie

@tomwilkie

This comment has been minimized.

Copy link
Member

tomwilkie commented Aug 21, 2017

Yes, this change has been ported to v2 yet. The remote code in master is ahead in many ways, once we get 1.8 out I'll sync them up.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.