Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper shutdown for rule manager #310

Closed
juliusv opened this Issue Jun 20, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@juliusv
Copy link
Member

juliusv commented Jun 20, 2013

The rule manager isn't properly shutdown anywhere when quitting Prometheus, causing it to try and access storage even after it has been drained.

@matttproud-soundcloud

This comment has been minimized.

Copy link
Contributor

matttproud-soundcloud commented Jun 21, 2013

You should speak with Bernerd, as he has a couple of great ideas around
life cycle management.

Message composed via terrorphone terrorcommunications device and is
probably fraught with typos and misspellings and syntax errors.
Am 21.06.2013 01:35 schrieb "juliusv" notifications@github.com:

The rule manager isn't properly shutdown anywhere when quitting
Prometheus, causing it to try and access storage even after it has been
drained.


Reply to this email directly or view it on GitHubhttps://github.com//issues/310
.

@juliusv juliusv closed this Dec 16, 2013

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#310 from prometheus/beorn7/storage
Rework storage documentation and add "rushed mode"
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.